-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the help information of cargo-rustc #7892
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! |
📌 Commit 367fe7b has been approved by |
Modified the help information of cargo-rustc ### Motivation The original help information for `cargo build` is > Compile a local package and all of its dependencies And the original help information for `cargo rustc` is > Compile a package and all of its dependencies These messages are **too similar** to make it difficult to distinguish the differences between the two commands. According to the [cargo book](https://doc.rust-lang.org/cargo/commands/cargo-rustc.html), `cargo rustc` is characterized by > pass extra options to the compiler I think this should be written into the help text of the command. In addition, the `<args> ...` parameters of `cargo rustc` lack help text and need to be added. ### Modification See the commit files. ### Problems Maybe some words in my modification are not accurate enough. If you have better wording, welcome to point out. Thanks.
☀️ Test successful - checks-azure |
Update cargo 11 commits in e02974078a692d7484f510eaec0e88d1b6cc0203..e57bd02999c9f40d52116e0beca7d1dccb0643de 2020-02-18 15:24:43 +0000 to 2020-02-21 20:20:10 +0000 - fix most remaining clippy findings (mostly redundant imports) (rust-lang/cargo#7912) - Add -Zfeatures tracking issues. (rust-lang/cargo#7917) - Use rust-lang/rust linkchecker on CI. (rust-lang/cargo#7913) - Clean up code mostly based on clippy suggestions (rust-lang/cargo#7911) - Add an option to include crate versions to the generated docs (rust-lang/cargo#7903) - Better support for license-file. (rust-lang/cargo#7905) - Add new feature resolver. (rust-lang/cargo#7820) - Switch azure to macOS 10.15. (rust-lang/cargo#7906) - Modified the help information of cargo-rustc (rust-lang/cargo#7892) - Update for nightly rustfmt. (rust-lang/cargo#7904) - Support `--config path_to_config.toml` cli syntax. (rust-lang/cargo#7901)
Motivation
The original help information for
cargo build
isAnd the original help information for
cargo rustc
isThese messages are too similar to make it difficult to distinguish the differences between the two commands.
According to the cargo book,
cargo rustc
is characterized byI think this should be written into the help text of the command.
In addition, the
<args> ...
parameters ofcargo rustc
lack help text and need to be added.Modification
See the commit files.
Problems
Maybe some words in my modification are not accurate enough. If you have better wording, welcome to point out. Thanks.